chore: use Cow in scalars/HexString #3034
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymnc
reviewed
Jun 9, 2025
|
|
||
| #[derive(Clone, Debug, derive_more::Into, derive_more::From, PartialEq, Eq)] | ||
| pub struct HexString(pub(crate) Vec<u8>); | ||
| pub struct HexString(pub(crate) Cow<'static, [u8]>); |
Member
There was a problem hiding this comment.
not sure if we want a static lifetime here, can we use
Suggested change
| pub struct HexString(pub(crate) Cow<'static, [u8]>); | |
| pub struct HexString<'a>(pub(crate) Cow<'a, [u8]>); |
instead?
Author
There was a problem hiding this comment.
@rymnc I've changed implementation to use 'a instead of 'static. Please review.
grandima
force-pushed
the
2657-scalars-HexString-cow
branch
2 times, most recently
from
7a9aec6 to
a571b5f
Compare
rymnc
reviewed
Jun 30, 2025
rymnc
reviewed
Jun 30, 2025
Author
|
@rymnc I applied the suggested changes. Please review. |
grandima
force-pushed
the
2657-scalars-HexString-cow
branch
from
5dcdbf0 to
06150af
Compare
grandima
force-pushed
the
2657-scalars-HexString-cow
branch
from
06150af to
ae7848d
Compare
grandima
commented
Nov 2, 2025
| // TODO: Avoid cloning the bytes here. | ||
| // https://github.com/FuelLabs/fuel-core/issues/2657 | ||
| HexString(bytes.as_ref().clone()) | ||
| HexString::from(bytes.as_ref().clone()) |
Author
There was a problem hiding this comment.
Cow::Owned is still needed here and as a result - cloning. Because Cow::Borrowed cannot be returned since it references only to a data that is owned by this map. Here's a compilation failing example if we use Cow::Borrowed:
error[E0515]: cannot return value referencing function parameter `bytes`
--> crates/fuel-core/src/schema/block.rs:443:21
|
443 | HexString::from(bytes.as_ref().as_slice())
| ^^^^^^^^^^^^^^^^-----^^^^^^^^^^^^^^^^^^^^^
| | |
| | `bytes` is borrowed here
| returns a value referencing data owned by the current function
Author
|
hey @rymnc please check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked Issues/PRs
close #2657
Description
Checklist
Before requesting review
After merging, notify other teams
[Add or remove entries as needed]
Note
Replaces owned HexString with Cow-backed HexString<'_> and updates GraphQL types/methods to borrow bytes where possible, reducing clones and adding required lifetimes.
HexStringwithHexString<'a>backed byCow<[u8]>.From<Vec<u8>>,From<&[u8]>,From<HexString> for Vec<u8>; updateDisplay,ScalarType,CursorType,FromStr, andNonceconversions to support borrowing.HexStringtoHexString<'_>across schema:blob,contract,da_compressed,message,storage,tx(queries, mutations, subscriptions, types, receipts), andupgrades.Input<'a>,InputCoin<'a>,InputMessage<'a>,UploadedBytecode<'a>, subscriptions).HexStringvia borrowing (HexString::from(&[..])/.into()) and remove unnecessary clones in mappers (e.g., witnesses, scripts, predicate/data, storage slots, block/tx streams).HexString<'_>where relevant.Written by Cursor Bugbot for commit ae7848d. This will update automatically on new commits. Configure here.